Skip to content

use the driver version explicitly to match libraries#1948

Merged
tariq1890 merged 1 commit into
mainfrom
explicit-driver-version-lib-matching
Jul 23, 2026
Merged

use the driver version explicitly to match libraries#1948
tariq1890 merged 1 commit into
mainfrom
explicit-driver-version-lib-matching

Conversation

@tariq1890

@tariq1890 tariq1890 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This is intended to replace the PR #1578.

It addresses some of the minor review comments and adds tests. The original author has been attributed and added as co-author.

Previous Behavior
The discovery logic used a generic . wildcard pattern to identify driver libraries. This was less precise and could potentially match unrelated files or incorrect versions.

 pattern := strings.TrimSuffix(libraryName, ".") + ".*.*"

Current Behavior
The update modifies graphicsDriverLibraries to explicitly use the detected driver version when constructing the match pattern. This ensures that only libraries matching the active driver version are processed, preventing false positives and ensuring consistency.

pattern := strings.TrimSuffix(libraryName, ".") + "." + d.driverVersion

@tariq1890
tariq1890 requested a review from cdesiniotis July 22, 2026 14:26
@coveralls

coveralls commented Jul 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29983631952

Coverage decreased (-0.02%) to 43.771%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 10 uncovered changes across 1 file (1 of 11 lines covered, 9.09%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
internal/discover/graphics.go 11 1 9.09%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
internal/discover/graphics.go 1 26.47%

Coverage Stats

Coverage Status
Relevant Lines: 15154
Covered Lines: 6633
Line Coverage: 43.77%
Coverage Strength: 0.49 hits per line

💛 - Coveralls

@tariq1890 tariq1890 self-assigned this Jul 22, 2026
Comment thread internal/discover/graphics_test.go
Comment thread internal/discover/graphics.go Outdated
@tariq1890
tariq1890 force-pushed the explicit-driver-version-lib-matching branch from 860bc1c to d4a22a5 Compare July 22, 2026 20:42
Co-authored-by: Ronit Sabhaya <ronitsabhaya75@gmail.com>
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890
tariq1890 force-pushed the explicit-driver-version-lib-matching branch from d4a22a5 to f95e1de Compare July 23, 2026 05:58
@tariq1890
tariq1890 merged commit 7b3c54b into main Jul 23, 2026
20 checks passed
@tariq1890
tariq1890 deleted the explicit-driver-version-lib-matching branch July 23, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants