Skip to content

Use XZ RPM compression during rpmrebuild#1950

Open
n-nagornyi wants to merge 1 commit into
NVIDIA:mainfrom
n-nagornyi:xz-rpm-compression
Open

Use XZ RPM compression during rpmrebuild#1950
n-nagornyi wants to merge 1 commit into
NVIDIA:mainfrom
n-nagornyi:xz-rpm-compression

Conversation

@n-nagornyi

Copy link
Copy Markdown

37dd08c that introduced rpmrebuild for 256bit digests brought a side effect: zstd RPM compression which is incompatible with Amazon Linux 2.

37dd08c that introduced rpmrebuild for 256bit digests brought a side
effect: zstd RPM compression which is incompatible with Amazon Linux 2.

Signed-off-by: Nikita Nagornyi <nagornyi@amazon.de>
@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@henry118

Copy link
Copy Markdown
Member

This patch looks reasonable to me.

@n-nagornyi can you confirm:

  1. The updated RPM correctly installs on AL2; and
  2. The updated RPM preserves the SHA-256 digest (which was why Use rpmrebuild instead of fpm to rebuild rpm packages #1612 introduced rpmrebuild)

Thanks.

@n-nagornyi

Copy link
Copy Markdown
Author
  1. Yes, the packages install on AL2.
  2. Yes, see the rpm output.
% rpm -qp --queryformat '%{SHA256HEADER}\n' nvidia-container-toolkit/dist/centos7/x86_64/nvidia-container-toolkit-1.19.1-1.x86_64.rpm
42a2ee59156d6cfac44e6fb6b86f11a5cc6d65b4db56502fa639b83df9560ace

% rpm -Kv nvidia-container-toolkit/dist/centos7/x86_64/nvidia-container-toolkit-1.19.1-1.x86_64.rpm
nvidia-container-toolkit/dist/centos7/x86_64/nvidia-container-toolkit-1.19.1-1.x86_64.rpm:
    Header SHA256 digest: OK
    Header SHA1 digest: OK
    Payload SHA256 digest: OK
    MD5 digest: OK

How can we proceed with packaging and signing the fixed version for Amazon Linux 2? Would it be possible to replace existing 1.19.0 and 1.19.1 packages or we have to wait for 1.20.0 release?

@henry118

Copy link
Copy Markdown
Member

Would it be possible to replace existing 1.19.0 and 1.19.1 packages or we have to wait for 1.20.0 release?

We are actively working on 1.20 release. please use 1.20 as the fixed version.

@cdesiniotis

Copy link
Copy Markdown
Contributor

/ok to test f2c2422

@cdesiniotis

cdesiniotis commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@n-nagornyi from https://docs.aws.amazon.com/AL2/latest/relnotes/relnotes-20251014.html it appears Amazon Linux 2 has reached end-of-life. Just curious why you are still looking to package new versions of NVIDIA Container Toolkit for Amazon Linux 2?

@n-nagornyi

Copy link
Copy Markdown
Author

We still need AL2 support for some time until full migration to AL2023.

When approximately can we expect 1.20.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants