Skip to content

fix(clang-format): update comment pragmas for copyright notice#3067

Closed
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:fix_clang_copyright_conflict
Closed

fix(clang-format): update comment pragmas for copyright notice#3067
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:fix_clang_copyright_conflict

Conversation

@gforsyth

@gforsyth gforsyth commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

After adding All rights reserved. to the end of the SPDX Copyright Header, the line is now too long and so clang-format wraps it, which then breaks the verify-copyright pre-commit hook.

Adding SPDX to the list of CommentPragmas so clang-format ignores them

@gforsyth gforsyth requested a review from a team as a code owner July 1, 2026 18:32
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 1, 2026
@aamijar aamijar mentioned this pull request Jul 2, 2026
@divyegala

Copy link
Copy Markdown
Contributor

I copied the diff of this commit in #3071 which fixes the failing docs build, which RAFT CI is currently blocked on.

@divyegala

Copy link
Copy Markdown
Contributor

I am closing this PR as I needed to copy this fix in #3071 to get the failing docs build working. Thanks @gforsyth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants