Skip to content

fix feature test for constexpr virtual functions #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 2 commits into from
Apr 30, 2026
+2 −2
Merged

fix feature test for constexpr virtual functions #2055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d4992
fix feature test for constexpr virtual functions
ericniebler Apr 29, 2026
128216c
give up on msvc and nvc++
ericniebler Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/stdexec/__detail/__diagnostics.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@ namespace STDEXEC
_WITH_PRETTY_SENDER_<_Sender>,
_WITH_ENVIRONMENT_(_Env)...>;

#if __cpp_lib_constexpr_exceptions >= 202502L // constexpr exception types, https://wg21.link/p3378
#if __cpp_lib_constexpr_exceptions >= 202502L

// constexpr stdlib exception types, https://wg21.link/p3378
using __exception = ::std::exception;

#elif __cpp_constexpr >= 202411L // constexpr virtual functions
#elif __cpp_constexpr >= 201907L && !STDEXEC_MSVC() && !STDEXEC_NVHPC()

// constexpr virtual functions
struct __exception
Expand Down
Loading