Skip to content

Complete start_now with no senders - #2163

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/start-now-empty
Open

Complete start_now with no senders#2163
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/start-now-empty

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • mark empty start_now storage as already complete
  • add a regression test for start_now(scope)

Why

start_now accepts an empty sender pack. The storage starts with a pending count of zero, but its joiner still points to the waiting state. async_wait() can then install a waiter even though no child can complete the storage. Initializing the joiner to the existing completed marker makes an empty pack complete immediately.

Testing

  • cmake --build build --target test.exec -j 8
  • ./build/test/exec/test.exec '[async_scope][start_now]'

@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@fallintoplace
fallintoplace marked this pull request as ready for review August 8, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant