Skip to content

Use automatic batching in tabular benchmarks - #1008

Closed
RBendias wants to merge 2 commits into
feat/automatic-estimator-batchingfrom
cleanup/benchmark-auto-batching
Closed

RBendias wants to merge 2 commits into
feat/automatic-estimator-batchingfrom
cleanup/benchmark-auto-batching

Conversation

@RBendias

Copy link
Copy Markdown
Collaborator

Remove the tabular benchmark adapter’s hard-coded estimator batching thresholds and manual batch loop. The adapter now forwards its estimator_batch_size setting directly to the model for both cached and uncached inference, so "auto" uses the library planner.

This keeps the batching infrastructure introduced in #989 while replacing the benchmark-specific 2,000/3,000-row and 50,000-cell decisions.

Depends on #1007. Related: #989 and #994.

@copy-pr-bot

copy-pr-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@RBendias
RBendias marked this pull request as ready for review September 28, 2026 15:45
@RBendias
RBendias force-pushed the feat/automatic-estimator-batching branch 2 times, most recently from 81f85a0 to 32e8a44 Compare September 29, 2026 10:35
@RBendias
RBendias force-pushed the cleanup/benchmark-auto-batching branch from 2697b25 to 404be1c Compare September 29, 2026 10:37
@RBendias
RBendias force-pushed the feat/automatic-estimator-batching branch from 32e8a44 to c8fc4f7 Compare September 29, 2026 10:45
@RBendias
RBendias force-pushed the cleanup/benchmark-auto-batching branch from 404be1c to 60dd30e Compare September 29, 2026 10:46
Signed-off-by: RBendias <rbendias@nvidia.com>
@RBendias
RBendias force-pushed the cleanup/benchmark-auto-batching branch from 60dd30e to 43cfdfb Compare September 29, 2026 13:20
Signed-off-by: RBendias <rbendias@nvidia.com>
@RBendias RBendias closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant