Skip to content

Ignore infinities when fitting ImputeMean - #1028

Draft
alaabenfatma wants to merge 1 commit into
NVIDIA:mainfrom
alaabenfatma:bug-impute-mean-inf
Draft

alaabenfatma wants to merge 1 commit into
NVIDIA:mainfrom
alaabenfatma:bug-impute-mean-inf

Conversation

@alaabenfatma

@alaabenfatma alaabenfatma commented Sep 29, 2026 •

Copy link
Copy Markdown

Fixes the MeanImpute item in #105.

ImputeMean now skips infinite values when it fits the per-column means. Before this change, a column whose infinities all had the same sign got an infinite mean, and every NaN in that column was filled with it. After Standardize and Clip in the TabICLv2 recipe, those missing cells ended up at the clip bound, the same as the infinite values. The transform still leaves infinite values as they are, and columns with no finite values fall back to fill_value. This matches Standardize, which already ignores infinities when fitting.

Signed-off-by: Alaa Ben Fatma <9027148+alaabenfatma@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant