Skip to content

Add incremental strict TypeScript ratchet - #1103

Merged
Manuelshub merged 1 commit into
Nanle-code:masterfrom
raymondidahor-bot:turn-on-typescript-mode
Sep 28, 2026
Merged

Manuelshub merged 1 commit into
Nanle-code:masterfrom
raymondidahor-bot:turn-on-typescript-mode

Conversation

@raymondidahor-bot

Copy link
Copy Markdown

Summary

Closes #

How was this tested?

Merge requirements

A PR is merged only when every box below is true. See
Merge requirements for the full policy.

  • All required CI checks pass on the latest commit (not just an earlier push).
  • No required checks are failing, pending, or skipped — re-run or fix them; do not ask for a merge while any are outstanding.
  • The branch has no merge conflicts with the target branch (rebase or merge master if GitHub shows "This branch has conflicts").
  • Tests were added or updated for the change (primary flow, a boundary case, and a failure case).
  • Docs were updated where behaviour, configuration, or security posture changed.

Security-sensitive changes

  • This PR touches a path covered by .github/CODEOWNERS (wallet, auth, cryptography, CI) and a code owner has been requested for review.
  • I described any change to key handling, signing, session lifetime, or trusted endpoints above.

Close #960

Summary

  • Add tsconfig.strict.json for the incremental strict TypeScript migration surface.
  • Add a ratchet check that rejects removal of existing approved entries.
  • Add CI and package scripts for the strict type check and allowlist validation.
  • Add tests for the baseline, an allowlist addition, and an attempted removal.
  • Document the contributor workflow and update the targeted Stellar read-source typing.

Validation

  • node scripts/check-strict-tsconfig.mjs passes.
  • pnpm exec vitest run tests/unit/strictTypeConfig.test.js --config vitest.config.js passes (3 tests).

Known issue

npx tsc -p tsconfig.strict.json --noEmit currently fails with TypeScript diagnostics, including errors in files pulled into the compilation through dependencies. The strict type-check CI gate is therefore not yet confirmed green and should be resolved before merge.

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@raymondidahor-bot is attempting to deploy a commit to the nanle-code's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@raymondidahor-bot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Manuelshub
Manuelshub merged commit 70f090b into Nanle-code:master Sep 28, 2026
4 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2026 Hardening] Turn on TypeScript strict mode incrementally with a per-directory ratchet

2 participants