Add integration tests for the portfolio analytics flow - #1105
Merged
Manuelshub merged 1 commit intoSep 28, 2026
Merged
Manuelshub merged 1 commit into
Manuelshub merged 1 commit into
Conversation
Adds two integration test suites covering the full dashboard pipeline — account balances → CoinGecko USD estimates → Recharts allocation/performance/risk views → CSV export — 67 tests, all passing. - tests/integration/portfolioAnalyticsCalculations.test.ts (52 tests) covers every portfolio calculation: USD pricing, unpriced assets, allocation, diversification, concentration, counterparty risk, volatility, Sharpe ratio, P&L, correlation, rebalancing, historical reconstruction, summaries, and CSV row generation. - tests/integration/portfolioAnalyticsFlow.test.tsx (15 tests) drives the real PortfolioValue component through two-, one-, five-, unpriced-, empty- and disconnected-account portfolios, plus loading, price-API failure, refresh recovery, and Horizon history failure. Only the seams are stubbed — the store, the Horizon server, and Recharts' ResponsiveContainer — so all pricing, analytics, chart and export code under test is production code. closes Nanle-code#251
|
@aishagbadamosi is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two integration test suites covering the full dashboard pipeline — account balances → CoinGecko USD estimates → Recharts allocation/performance/risk views → CSV export — 67 tests, all passing.
closes #251
Summary
Adds two integration test suites covering the full dashboard pipeline — account balances → CoinGecko USD estimates → Recharts allocation/performance/risk views → CSV export — 67 tests, all passing.
Closes #251
How was this tested?
Merge requirements
A PR is merged only when every box below is true. See
Merge requirements for the full policy.
masterif GitHub shows "This branch has conflicts").Security-sensitive changes
.github/CODEOWNERS(wallet, auth, cryptography, CI) and a code owner has been requested for review.