Skip to content

fix(cookies): preserve values containing equals #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(cookies): preserve values containing equals #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ def test_convert_cookies():
assert cookie_dict.get("a1") == "x000101360"


def test_convert_str_cookie_to_dict_preserves_equals_in_cookie_values():
cookie_dict = utils.convert_str_cookie_to_dict("session=eyJhbGciOiJIUzI1NiJ9==; theme=dark")

assert cookie_dict == {"session": "eyJhbGciOiJIUzI1NiJ9==", "theme": "dark"}


@pytest.mark.asyncio
async def test_convert_browser_context_cookies_uses_url_filter():
browser_context = AsyncMock()
Expand Down
2 changes: 1 addition & 1 deletion tools/crawler_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def convert_str_cookie_to_dict(cookie_str: str) -> Dict:
cookie = cookie.strip()
if not cookie:
continue
cookie_list = cookie.split("=")
cookie_list = cookie.split("=", 1)
if len(cookie_list) != 2:
continue
cookie_value = cookie_list[1]
Expand Down