Conversation
Contributor
|
Is this ready for merging? cc @lxvm |
Collaborator
Author
|
Yes from my side. There are still several things to be improved upon, such creating a unified test suite for SSP1 and SSP2 (right now they are duplicated), and comparing Python against Julia implementation. However, this initial implementation is self-contained and can be used right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an initial Python implementation of SSP2.
Known limitations
0.7.2: Newer versions throw the following error when combining FFT-based filtering withinterpaxinterpolation:Example and test: Currently copied from the SSP1 counterparts with just the projection method switched.