Skip to content

Add shared architecture-docs submodule + CLAUDE.md#99

Merged
xTRam1 merged 11 commits intomainfrom
add-architecture-docs-submodule
May 1, 2026
Merged

Add shared architecture-docs submodule + CLAUDE.md#99
xTRam1 merged 11 commits intomainfrom
add-architecture-docs-submodule

Conversation

@xTRam1
Copy link
Copy Markdown
Contributor

@xTRam1 xTRam1 commented Apr 30, 2026

Summary

Wires the new NaradaAI/architecture-docs repo (merged in PR #1) into narada-python-sdk as a git submodule at architecture-docs/. This is one of three sibling consumer PRs (also opened in caddie and frontend).

Pinned at architecture-docs commit d2a82e1c (main HEAD as of this PR update).

What's in this PR

  • .gitmodules (new) — first submodule entry: architecture-docs../architecture-docs.git, tracking branch main. Relative URL pattern works for SSH and HTTPS parent clones.
  • architecture-docs/ — gitlink (mode 160000) pinning the submodule.
  • CLAUDE.md (new) — top-level project context for AI coding agents, including a bootstrap command for fresh clones before linking to shared docs. python-sdk.md is emphasized as the most relevant doc for this repo.
  • .github/workflows/architecture-docs-freshness.yml (new) — compares the pinned gitlink against architecture-docs/main, with explicit contents: read permissions.

No source code touched. Pure config + docs.

Note on this repo being PUBLIC

Fork PRs and Dependabot PRs may not receive normal Actions secrets under the pull_request trigger, so those runs emit an explicit warning and skip freshness enforcement. If we want enforcement for those sources too, we should move this check to a carefully scoped pull_request_target or equivalent trusted workflow that never checks out or executes untrusted PR code.

Freshness check behavior

The workflow uses ${{ secrets.ARCHITECTURE_DOCS_READ_PAT }} (a fine-grained PAT with read access to NaradaAI/architecture-docs) when available. If the secret is absent, the job emits an explicit warning and exits 0, so this PR can land before repo secrets are configured.

This means freshness is enforced only on runs that receive ARCHITECTURE_DOCS_READ_PAT.

Follow-up needed after merge

Add ARCHITECTURE_DOCS_READ_PAT to this repo's Actions secrets to enable freshness enforcement.

Test plan

  • Worktree off origin/main — clean isolation from any in-flight working branches
  • git -C architecture-docs rev-parse HEAD matches d2a82e1c76af3e702a13cd760f39af02bdf2bc0e
  • .gitmodules parses cleanly
  • git diff --check
  • YAML parses locally via Ruby/Psych
  • Targeted git submodule update --init architecture-docs path succeeds locally with an authenticated GitHub token
  • Local pinned-vs-remote comparison matches architecture-docs/main

Wires NaradaAI/architecture-docs as a git submodule at architecture-docs/
(relative URL, branch=main). Adds a top-level CLAUDE.md pointing at the
shared docs with python-sdk.md emphasized, and a small GitHub Actions
workflow that fails when the submodule pointer falls behind
architecture-docs/main.

The freshness check uses ARCHITECTURE_DOCS_READ_PAT (needs to be added
as a repo secret with read access to NaradaAI/architecture-docs). Until
the secret is configured, the check emits a warning annotation and
exits 0 so this PR can land cleanly. Note: this repo is public, so PRs
from forks won't have access to the secret — graceful-degrade ensures
those PRs still pass.
Comment thread .github/workflows/architecture-docs-freshness.yml Fixed
@xTRam1 xTRam1 merged commit 0825089 into main May 1, 2026
5 checks passed
@xTRam1 xTRam1 deleted the add-architecture-docs-submodule branch May 1, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants