Check PyPi publishability in every PR#451
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PyPI publishing workflow to validate that the Python package can be built and passes twine check --strict on every PR (and main push), while keeping actual publishing restricted to release flows.
Changes:
- Add
pull_request+pushtriggers (scoped to packaging-relevant paths) to build artifacts on every PR / main update. - Add a
twine check --strict dist/*validation step after building wheels/sdist. - Gate the PyPI publish action behind specific event types.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 56.11% 56.44% +0.32%
==========================================
Files 63 66 +3
Lines 6080 6279 +199
Branches 591 614 +23
==========================================
+ Hits 3412 3544 +132
- Misses 2598 2662 +64
- Partials 70 73 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
37
to
40
| permissions: | ||
| # IMPORTANT: write permission is mandatory for Trusted Publishing | ||
| id-token: write | ||
| contents: read |
ppinchuk
requested changes
May 28, 2026
Collaborator
ppinchuk
left a comment
ppinchuk
left a comment
There was a problem hiding this comment.
Cool to see that it's already working as intended :P
Closed
ppinchuk
previously approved these changes
May 28, 2026
ppinchuk
previously approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #449
Run
twine check --strictto catch potential issues in publishing to PyPi in every PR.Only do the actual publish on release.