Update lab name, links, license, and emails. Change author order.#102
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 45 45
Lines 2325 2325
=======================================
Hits 1933 1933
Misses 392 392 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scdhulipala
requested changes
Feb 17, 2026
| # Acknowledgments | ||
|
|
||
| Special thanks to NREL's Trieu Mai, Paul Denholm, and Greg Brinkman for their | ||
| Special thanks to NatLabRockies's Trieu Mai, Paul Denholm, and Greg Brinkman for their |
Member
Author
There was a problem hiding this comment.
Isn't on sabbatical, and this acknowledgment is from before so do we need to update it?
There was a problem hiding this comment.
Often acknowledgments don't include affiliations (since they change over time), so a simpler option would just be to list the names without affiliation.
| Special thanks to NatLabRockies's Trieu Mai, Paul Denholm, and Greg Brinkman for their | ||
| support and feedback in preparing this work, and to Sarah Awara and Sinnott | ||
| Murphy (NREL), as well as Armando Figueroa Acevedo (Black & Veatch), for | ||
| Murphy (NatLabRockies), as well as Armando Figueroa Acevedo (Black & Veatch), for |
| in the [`master`](https://github.com/NatLabRockies/PRAS/tree/master) branch of the PRAS github | ||
| repository. Documentation for this version is available [here] | ||
| (https://docs.nrel.gov/docs/fy21osti/79698.pdf). | ||
| (https://docs.NatLabRockies.gov/docs/fy21osti/79698.pdf). |
| ## Parallel Processing | ||
|
|
||
| PRAS uses multi-threading, so be sure to set the environment variable controlling the number of threads available to Julia (36 in this Bash example, which is a good choice for NREL Eagle nodes - on a laptop you would probably only want 4 or so) before running scripts or launching the REPL: | ||
| PRAS uses multi-threading, so be sure to set the environment variable controlling the number of threads available to Julia (36 in this Bash example, which is a good choice for NatLabRockies Eagle nodes - on a laptop you would probably only want 4 or so) before running scripts or launching the REPL: |
There was a problem hiding this comment.
Do we want to say kestrel and link the page here? Also, do we want to include the command to configure the # of threads automatically?
|
I had some comments (mostly nitpicky). |
scdhulipala
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.