Skip to content

Make the whole iOS button group segment tappable #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmitchell85 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the whole iOS button group segment tappable #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions resources/ios/NativeUIButtonGroupRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ struct NativeUIButtonGroupRenderer: View {
.frame(maxWidth: .infinity)
.foregroundStyle(isSelected ? theme.onPrimary : theme.onSurface)
.background(isSelected ? theme.primary : Color.clear)
// A plain-style button only hit-tests drawn content, so an
// unselected segment's clear background would leave just the
// label tappable. Make the whole segment the tap target.
.contentShape(Rectangle())
}
.buttonStyle(.plain)
.disabled(disabled)
Expand Down