fix: report WebRTC initialization failures without probing - #88
Closed
thejustinwalsh wants to merge 6 commits into
Closed
thejustinwalsh wants to merge 6 commits into
thejustinwalsh wants to merge 6 commits into
Conversation
Xcode 27 moved SimulatorKit.framework out of Contents/Developer/Library/PrivateFrameworks and into Contents/SharedFrameworks. The old directory is gone, so the display bridge failed with "Unable to load SimulatorKit". The bridge now reads the Xcode major version from version.plist next to the developer directory. On 27 and later it tries SharedFrameworks first and falls back to the old location. On older or unknown versions it tries the old location first. If neither file exists it returns the first candidate so the error still names the expected path.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thejustinwalsh
marked this pull request as draft
October 1, 2026 14:49
thejustinwalsh
changed the title
thejustinwalsh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened this in error, I block WebRTC because it leaks my ip address, this confused the bots. I do think a WebTransport version would be nice.
Slop
Attempt the intended WebRTC connection directly, without creating and immediately closing a disposable capability-probe connection. If the real constructor throws, report the original initialization error and stop automatic reconnect attempts for that failure. Explicit reconnects remain possible; ordinary negotiation/network failures retain existing recovery behavior. AppShell retains its existing control WebSocket fallback; no video fallback or extension bypass is introduced.
The initial probe-based patch was replaced after browser comparison. In the affected Chrome session, the real connection still fails with
RTCPeerConnection is not a constructor; the user reports a WebRTC privacy extension is installed. This PR improves error handling and does not claim to resolve that override. The user reports Safari and the ChatGPT side panel working.Validation for commit 2918cd8:
The branch includes #87's Xcode framework-path prerequisite; this browser change is separate from that fix and should be rebased when #87 lands. No native HID ABI fix is included. Kept in draft pending final scope review and cross-browser verification of the latest build.