Skip to content

chore: remove extensions note that appeared as a warning #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −23
Open

chore: remove extensions note that appeared as a warning #6137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions lib/services/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,14 +1574,12 @@ export class IOSProjectService
);
const platformData = this.getPlatformData(projectData);
const pbxProjPath = this.getPbxProjPath(projectData);
const addedExtensionsFromResources =
await this.$iOSExtensionsService.addExtensionsFromPath({
extensionsFolderPath: resorcesExtensionsPath,
projectData,
platformData,
pbxProjPath,
});
let addedExtensionsFromPlugins = false;
await this.$iOSExtensionsService.addExtensionsFromPath({
extensionsFolderPath: resorcesExtensionsPath,
projectData,
platformData,
pbxProjPath,
});
for (const pluginIndex in pluginsData) {
const pluginData = pluginsData[pluginIndex];
const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath(
Expand All @@ -1592,21 +1590,12 @@ export class IOSProjectService
pluginPlatformsFolderPath,
constants.NATIVE_EXTENSION_FOLDER,
);
const addedExtensionFromPlugin =
await this.$iOSExtensionsService.addExtensionsFromPath({
extensionsFolderPath: extensionPath,
projectData,
platformData,
pbxProjPath,
});
addedExtensionsFromPlugins =
addedExtensionsFromPlugins || addedExtensionFromPlugin;
}

if (addedExtensionsFromResources || addedExtensionsFromPlugins) {
this.$logger.warn(
"Let us know if there are other Extension features you'd like! https://github.com/NativeScript/NativeScript/issues",
);
await this.$iOSExtensionsService.addExtensionsFromPath({
extensionsFolderPath: extensionPath,
projectData,
platformData,
pbxProjPath,
});
}
}

Expand Down