Add: warnings to gas and deco plan when PPO2 becomes hypoxic or exceeds configured limits - #216
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 64.49% 64.50%
=======================================
Files 144 144
Lines 8005 7998 -7
Branches 1836 1834 -2
=======================================
- Hits 5163 5159 -4
+ Misses 1772 1769 -3
Partials 1070 1070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rolf-Smit
force-pushed
the
feature/hypoxic-warnings
branch
3 times, most recently
from
September 13, 2026 20:23
684f155 to
34e8876
Compare
Rolf-Smit
changed the title
…ds configured limits This commit also adds oxygen toxicity warnings to the deco plan, as previously the deco plan did not show any PPO2 related alerts. All PPO2 related warnings now show a yellow (warning level) background when the PPO2 exceeds the diver's configured limit, and a red (error level) background at or above the fixed 1.6 bar ceiling (or below the hypoxic minimum) regardless of configuration. The deco table now also shows PPO2 with two decimals instead of one, inline with the gas plan's limits table. It no longer shows a start-to-end PPO2 range for certain closed-circuit segments, only the ending PPO2, which is consistent with the depth and runtime columns which are also end-of-segment.
Rolf-Smit
force-pushed
the
feature/hypoxic-warnings
branch
from
September 13, 2026 20:37
34e8876 to
99ecf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit also adds oxygen toxicity warnings to the deco plan, as previously the deco plan did not show any PPO2 related alerts. All PPO2 related warnings now show a yellow (warning level) background when the PPO2 exceeds the diver's configured limit, and a red (error level) background at or above the fixed 1.6 bar ceiling (or below the hypoxic minimum) regardless of configuration.
The deco table now also shows PPO2 with two decimals instead of one, inline with the gas plan's limits table. It no longer shows a start-to-end PPO2 range for certain closed-circuit segments, only the ending PPO2, which is consistent with the depth and runtime columns which are also end-of-segment.