[installer] allow labeled installation namespaces#1143
Open
patrick-men wants to merge 2 commits intoNetApp:masterfrom
Open
[installer] allow labeled installation namespaces#1143patrick-men wants to merge 2 commits intoNetApp:masterfrom
patrick-men wants to merge 2 commits intoNetApp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Allow the installation of trident-operator in pre-labeled namespaces
Project tracking
Open Source Contribution, outside of your Jira scope
Do any added TODOs have an issue in the backlog?
Unknown
Did you add unit tests? Why not?
All tests have been added
Does this code need functional testing?
Check the tests I wrote, else let me know
Is a code review walkthrough needed? why or why not?
No, it's a small change in the logic for checking the installation namespace. Functions should be descriptive enough, else let me know
Should additional test coverage be executed in addition to pre-merge?
No
Does this code need a note in the changelog?
Yes, as this adds a new option for the installation
Does this code require documentation changes?
Yes, same reasoning as above.
Additional Information
The goal of this PR is to allow the use of an installation namespace that is already labelled with the trident-required namespace labels.
We've encountered this issue due to our multi tenancy setup: We do not allow tenants to label their own namespaces, whereas creating namespaces is allowed. As such, we hit a wall when trying to rollout the trident-operator - as of now, whether it created the namespace itself or not, it always tries to patch some labels.
With the small additions in the code, the operator now performs a check to see if the labels already exist, allowing for a more flexible deployment.
CCLA created and signed