Fixed a potential WebSocketException crash that would print to console without getting logged by the logger first.#338
Open
AraHaan wants to merge 2 commits intoNetCordDev:alphafrom
Conversation
…onsole without getting logged via the logger when the user just so happens to lose internet (say router gets rebooted by ISP) right when Discord wants ``ResumeAsync`` to be called. This also fixes the issue at startup as well where the user infortunately gets hit by this as soon as they start their bot, but just before any attempt is made to connect to discord (there is a small window between ``Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)`` and ``NetCord.Gateway.GatewayClient.StartAsync(PresenceProperties presence, CancellationToken cancellationToken)`` prior to the call to ``StartAsync`` in WebSocketClient. The fix here is to instead log the exceptions via the logger.
AraHaan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a potential WebSocketException crash that would print to console without getting logged via the logger when the user just so happens to lose internet (say router gets rebooted by ISP) right when Discord wants
ResumeAsyncto be called. This also fixes the issue at startup as well where the user unfortunately gets hit by this as soon as they start their bot, but just before any attempt is made to connect to discord (there is a small window betweenMicrosoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)andNetCord.Gateway.GatewayClient.StartAsync(PresenceProperties presence, CancellationToken cancellationToken)prior to the call toStartAsyncin WebSocketClient.The fix here is to instead log the exceptions via the logger before rethrowing.