Public release#8
Merged
Merged
Conversation
bad_successor and tier0_session_exposure each wrapped their whole body — including the Neo4j query — in a catch-all except that returned empty, so a Cypher error or schema drift was indistinguishable from "no findings". The framework manager already records check exceptions to diagnostics, so removing the swallow surfaces failures loudly instead of silently.
…cipals The check flagged only 5 well-known groups (CRITICAL_GROUPS_BY_SID) and scanned OUs only; DANGEROUS_PERMISSIONS held 6 entries the query could never emit. Per the BadSuccessor research, any enabled non-Tier-0 principal with full control of an OU or container is exploitable. - neo4j_data: widen the query to OU or Container, drop disabled principals - bad_successor: remove the dead DANGEROUS_PERMISSIONS set and the CRITICAL_GROUPS_BY_SID post-filter; emit a finding per returned row - fixture/test: cover a Container and a non-well-known principal; assert disabled and Tier-0 principals are excluded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.