fix(tasks): update styles watcher to support chokidar v4#141
Open
Hugoer wants to merge 2 commits into
Open
Conversation
Member
|
Issues Found
|
Member
Author
|
Thanks for reviewing! changes made:
The glob import was already present on line 2, so nothing to add there. |
infloent
reviewed
May 15, 2026
| absolute: true | ||
| }); | ||
|
|
||
| const watcher = chokidar.watch(files, { |
There was a problem hiding this comment.
Instead of creating a huge static list of paths with glob why not use something like this which translates to the previous behavior?
chokidar.watch(config.general.sourcesPath, {
ignored: (filePath, stats) => stats?.isFile() && !filePath.endsWith(`.${config.general.sourceKey}.scss`),
ignoreInitial: true
});
There was a problem hiding this comment.
I saw the issue description after I left my comment. The why of the solution I think should be clearly stated also in the PR description in addition to the link to the issue.
The current proposal could seem to be the only alternative with chokidar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with SCSS file watchers caused by Chokidar version > 3. In versions 4+, Chokidar no longer supports glob patterns directly.
Description
Chokidar v4 removed support for glob patterns in
watch().This PR updates the styles watcher to handle that breaking change by pre-resolving SCSS files via
fast-globbefore passing them to chokidar.Related Issue
Fixes #138
Types of changes
Checklist: