fix(ipsec): add restart dpd_action#1676
Merged
Merged
Conversation
gsanchietti
force-pushed
the
nethsecurity-8.8
branch
from
ef5c857 to
f23b035
Compare
The init file from upstream replaces the dpd_action option values. Notably it replaces `restart` with `start`, but `start` value is not supported by Strongswan 6. Make sure if `restart` is set, the value is preserved. From the manual: Action to perform for this CHILD_SA on DPD timeout. The default clear closes the CHILD_SA and does not take further action. trap installs a trap policy, which will catch matching traffic and tries to re-negotiate the tunnel on-demand (note that this is redundant if start_action includes trap. restart immediately tries to re-negotiate the CHILD_SA under a fresh IKE_SA.
gsanchietti
force-pushed
the
issue1298
branch
2 times, most recently
from
f84ef1f to
9b76cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init file from upstream replaces the dpd_action option values. Notably it replaces
restartwithstart, butstartvalue is not supported by Strongswan 6.Make sure if
restartis set, the value is preserved.From the manual:
Action to perform for this CHILD_SA on DPD timeout. The default clear closes the CHILD_SA
and does not take further action. trap installs a trap policy, which will catch matching traffic
and tries to re-negotiate the tunnel on-demand (note that this is redundant if start_action includes trap.
restart immediately tries to re-negotiate the CHILD_SA under a fresh IKE_SA.
Fixes: #1298