Skip to content

Add NEURON 9 compatibility to mod files#822

Closed
JCGoran wants to merge 5 commits intoNeuralEnsemble:masterfrom
neuronsimulator:jelic/neuron_9_compat
Closed

Add NEURON 9 compatibility to mod files#822
JCGoran wants to merge 5 commits intoNeuralEnsemble:masterfrom
neuronsimulator:jelic/neuron_9_compat

Conversation

@JCGoran
Copy link
Copy Markdown

@JCGoran JCGoran commented Oct 8, 2025

Most of the fixes were borrowed from https://github.com/ModelDBRepository/249463/pull/1/files.

@JCGoran JCGoran mentioned this pull request Oct 13, 2025
Closed
JCGoran
JCGoran commented Oct 16, 2025
View reviewed changes
Comment thread pyNN/neuron/nmodl/tsodyksmarkram.mod
ENDCOMMENT

NEURON {
THREADSAFE
Copy link
Copy Markdown
Author

@JCGoran JCGoran Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in neuronsimulator/nrn#3638, in particular neuronsimulator/nrn#3638 (comment)

@JCGoran JCGoran marked this pull request as ready for review October 22, 2025 06:39
@apdavison
Copy link
Copy Markdown
Member

apdavison commented May 3, 2026 •
edited
Loading

The mod file changes (RANDCAST guards, scop_random(), THREADSAFE) were already applied to master in commit 8699516, which used the same EBRAINS patch, so this PR conflicts. The simulator.py load_mechanisms simplification has been applied separately in 0d45671.

@apdavison apdavison closed this May 3, 2026
apdavison added a commit that referenced this pull request May 3, 2026
@apdavison
Simplify load_mechanisms() to use neuron.load_mechanisms()
0d45671 
NEURON's own load_mechanisms() handles platform detection (including
.dylib on macOS) via mechanism_suffix, making the hand-rolled arch/
extension loop redundant.

Remaining change from #822; mod file changes were already applied
in 8699516.
@apdavison apdavison added this to the 0.13.0 milestone May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NEURON

Projects

None yet

Milestone

0.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JCGoran @apdavison