Move the page title into the top header - #34
Merged
Merged
Conversation
Derive the title from the active nav item and render it in the header bar, replacing the duplicated app name. Content areas no longer repeat the section heading; action rows stay right-aligned. Detail and edit pages keep their own content headings.
Replace the nav-derived title with an explicit title prop passed by each route, so detail and edit pages show a specific heading (the entity name with the operation) instead of the list-level title. Remove the remaining per-page content headings so every page has exactly one h1, in the header.
Prefix the medication name to the history detail and edit header titles, matching the drug pages instead of a generic static label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
yarn typecheck/yarn lint/yarn buildgreen.