[FEAT] 애플 소셜로그인 서버 연동 - #8
Merged
Merged
Conversation
- LoginState 현재 앱 로그인 여부 상태값 - KeyChainManager 키체인 관리 유틸 - TokenStorage 토큰값 저장소 유틸
- Auth관련 Endpoint - Auth관련 Repository 및 DTO 모델
cchanmi
reviewed
Jul 30, 2026
Contributor
Author
There was a problem hiding this comment.
@cchanmi 지금 Endpoint에서 헤더값에 디폴트로 넣고있는데 추후에 토큰값을 넣어야하는 경우에 따른 HeaderType도 넣으면 깔끔할꺼같아요 👍
cchanmi
approved these changes
Jul 30, 2026
cchanmi
left a comment
cchanmi
left a comment
Collaborator
There was a problem hiding this comment.
고생하셨어요
로그인 정상 동작 확인했습니다~
Comment on lines
+17
to
+21
| let query = [kSecAttrService: service, | ||
| kSecClass: account.keyChainClass, | ||
| kSecAttrAccount: account.description, | ||
| kSecValueData: data.data(using: .utf8, allowLossyConversion: false)!] as CFDictionary | ||
|
|
Collaborator
There was a problem hiding this comment.
실패시 crash 발생이라 guard let을 사용하는 것도 좋을 것 같습니다
- public >> privacy
- AuthError tokenStorageFailed 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe
Apple 소셜 로그인 및 Firebase Authentication 연동을 구현하고 서버 로그인 API 연동을 위한 네트워크 계층을 구성했습니다.
Works made
Changes Made
As-Is
기존 로직
스크린샷
없음
To-BE
변경 로직
스크린샷
없음
How to Test
Issues Resolved
Additional context
References
키체인 공식 문서 링크