Skip to content

fix: place-order form below the orders list (stops the filter tab-jump) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanMat merged 1 commit into from
Aug 30, 2026
Merged

fix: place-order form below the orders list (stops the filter tab-jump) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/CommerceAdmin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,18 @@ public function render(string $csrf = '', ?string $notice = null, ?string $statu

$html = '<div class="nb-page-head"><h1>Commerce</h1></div>' . $banner
. '<p class="nb-muted" style="margin:-8px 0 20px">Orders reserve stock against Inventory. '
. 'Place an order below and advance it with the buttons, or drive the lifecycle over MCP.</p>'
. $this->datalist($skus)
. $this->placeForm($csrf);
. 'Advance an order with its buttons, place a new one below, or drive the lifecycle over MCP.</p>'
. $this->datalist($skus);

// Lead with the orders list + filter, so changing the filter (a page load)
// lands here on the list — not scrolled up to the place form.
$html .= $this->statusFilter($status);

if ($orders === []) {
$html .= $status === null
? '<p class="nb-muted">No orders yet. Place one above, or with the <code>shop_place_order</code> tool.</p>'
? '<p class="nb-muted">No orders yet. Place one below, or with the <code>shop_place_order</code> tool.</p>'
: '<p class="nb-muted">No ' . $this->e($status) . ' orders.</p>';
return $html;
return $html . $this->placeForm($csrf);
}

$html .= '<div class="nb-table-wrap nb-stack"><table class="nb-table"><thead><tr>'
Expand All @@ -116,7 +117,7 @@ public function render(string $csrf = '', ?string $notice = null, ?string $statu
}

$html .= '</tbody></table></div>';
return $html;
return $html . $this->placeForm($csrf);
}

/** A coloured status pill using theme tokens (dark-safe). */
Expand Down Expand Up @@ -203,7 +204,7 @@ private function placeForm(string $csrf): string
. '<input id="ord-' . $this->e($name) . '" name="' . $this->e($name) . '"' . $list . ' placeholder="' . $this->e($ph) . '"></div>';
};

return '<form class="nb-form-card" method="post" action="/admin/commerce/place" style="margin-bottom:1.5rem">'
return '<form class="nb-form-card" method="post" action="/admin/commerce/place" style="margin-top:1.5rem">'
. '<h2>Place an order</h2>'
. '<input type="hidden" name="_token" value="' . $this->e($csrf) . '">'
. '<div style="display:flex;gap:1rem;flex-wrap:wrap;align-items:flex-end">'
Expand Down
Loading