fix: admin styling to a nonce'd <style> block (CSP is nonce-only) - #4
Merged
Merged
Conversation
…e-only) The admin CSP is nonce-only for style-src (no 'unsafe-inline'), so the inline style="" attributes on the Inventory admin page (form-card flex layout, filter row, right-aligned numeric columns, heading spacing, drill-down margins) were being DROPPED by the browser — the multi-column forms collapsed and numbers weren't right-aligned on the live admin. Emit one nonce-carrying <style> block per render (the page handler already receives the CSP nonce as its 2nd arg) covering both the overview and the drill-down, and replace every inline style= with a class. Tests: a new guard asserts a <style nonce=…> block is emitted and NO inline style= attribute survives, on both the overview and the drill-down. 48 tests green; PHPStan + php-cs-fixer clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to plugin-commerce#4. The admin CSP is nonce-only for
style-src, so the inlinestyle=""on the Inventory admin page (form-card flex, filter row, right-aligned numeric columns, heading spacing, drill-down margins) was dropped by the browser — multi-column forms collapsed and numbers weren't right-aligned on the live admin.Fix
Emit one nonce-carrying
<style>block per render (the handler already receives the CSP nonce) covering both the overview and the drill-down, and replace every inlinestyle=with a class.Tests
New guard: a
<style nonce=…>block is emitted and no inlinestyle=survives, on both the overview and the drill-down. 48 tests green; PHPStan + php-cs-fixer clean.🤖 Generated with Claude Code