Cart-count summary endpoint for content-page badges (ADR 0017) - #6
Merged
Merged
Conversation
Add a public GET /ext/shop/cart/summary → {count} (no-store, JSON), so a theme can
show the cart count on a page-CACHED content page without baking a per-visitor
count into the shared cache. Read-only (StorefrontCart::summary, never mints); the
count is a pure function of the caller's own opaque HttpOnly nb_cart cookie (no id
param → no IDOR; no cookie → 0). Count only — no lines, token, or PII. Being JSON
+ no-store keeps it out of the page cache (core caches only 200 text/html).
Reviewed via both skills, security-green. Tests: count-only JSON + no-store never
cached; no cart → 0; reading never mints.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public
GET /ext/shop/cart/summary→{count}(JSON,no-store), so a theme can show the cart count on a page-cached content page without baking a per-visitor count into the shared cache.summary(), never mints); the count is a pure function of the caller's own opaque HttpOnlynb_cartcookie (no id param → no IDOR; no cookie → 0).no-storekeeps it out of the page cache (core caches only200 text/html), so it can never leak across visitors.Reviewed via both skills, security-green. Tests: count-only JSON +
no-store(never cached); no cart → 0; reading never mints. Pairs with the Aurora header fetch (separate PR).🤖 Generated with Claude Code