Skip to content

fix(lighting): calibrate studio inspection lighting and add ACES/AgX tone mapping to prevent color blowout - #53

Merged
BharathASL merged 1 commit into
mainfrom
fix/calibrate-studio-lighting
Sep 29, 2026
Merged

BharathASL merged 1 commit into
mainfrom
fix/calibrate-studio-lighting

Conversation

@BharathASL

Copy link
Copy Markdown
Contributor

Description

Configure ACES Filmic tone mapping and exposure 1.0 on all viewport WebGLRenderer instances to prevent specular and diffuse highlight blowout and color clamping on high-intensity surfaces.

Calibrate the studio-neutral preset as the default lighting setup (DEFAULT_LIGHTING_PRESET = "studio-neutral") using pure neutral white illumination (#ffffff) across key (1.0), ambient (0.4), fill (0.3), and rim (0.2) lights to ensure true neutral, unbiased color reproduction during texture inspection. Soften trailer-golden-hour directional sun intensity from 1.8 to 1.2 and ambient fill from 0.6 to 0.4 to prevent color burnout and preserve underlying texture hue across sunlit faces.

Expose configureToneMapping helper in lighting-presets.js supporting both ACES Filmic and AgX tone mapping profiles, update existing test expectations, and add verification tests in tools/test/lighting-presets.test.mjs and tools/test-e2e.mjs.

Related Issues

Closes #49

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation / Hygiene update

Checklist

  • My code follows the style of the surrounding code.
  • I have run this repository's tests locally and they pass.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated documentation / CHANGELOG as appropriate. (No separate changelog or doc updates required for internal lighting and renderer calibration)
  • My commits follow Conventional Commits.
  • Every commit is signed off (git commit -s), per section 5 of CONTRIBUTING.md.

…tone mapping to prevent color blowout

Signed-off-by: Bharath <bharathasl74185@gmail.com>

@ninja6-agent ninja6-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@BharathASL
BharathASL added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit ea18c37 Sep 29, 2026
4 checks passed
@BharathASL
BharathASL deleted the fix/calibrate-studio-lighting branch September 29, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(lighting): calibrate studio inspection lighting and add ACES/AgX tone mapping to prevent color blowout

1 participant