Repository navigation
fix(lighting): calibrate studio inspection lighting and add ACES/AgX tone mapping to prevent color blowout - #53
Merged
Conversation
…tone mapping to prevent color blowout Signed-off-by: Bharath <bharathasl74185@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure ACES Filmic tone mapping and exposure 1.0 on all viewport WebGLRenderer instances to prevent specular and diffuse highlight blowout and color clamping on high-intensity surfaces.
Calibrate the
studio-neutralpreset as the default lighting setup (DEFAULT_LIGHTING_PRESET = "studio-neutral") using pure neutral white illumination (#ffffff) across key (1.0), ambient (0.4), fill (0.3), and rim (0.2) lights to ensure true neutral, unbiased color reproduction during texture inspection. Softentrailer-golden-hourdirectional sun intensity from 1.8 to 1.2 and ambient fill from 0.6 to 0.4 to prevent color burnout and preserve underlying texture hue across sunlit faces.Expose
configureToneMappinghelper inlighting-presets.jssupporting both ACES Filmic and AgX tone mapping profiles, update existing test expectations, and add verification tests intools/test/lighting-presets.test.mjsandtools/test-e2e.mjs.Related Issues
Closes #49
Type of Change
Checklist
git commit -s), per section 5 of CONTRIBUTING.md.