libstore: Plug thread safety issues in recursive-nix#15679
Open
libstore: Plug thread safety issues in recursive-nix#15679
Conversation
github-actions
Bot
added
the
store
xokdvium
commented
Apr 13, 2026
|
|
||
| std::pair<std::filesystem::path, std::filesystem::path> addDependencyPrep(const StorePath & path) | ||
| { | ||
| DerivationBuilderImpl::addDependencyImpl(path); |
Contributor
Author
There was a problem hiding this comment.
This was just adding to addedPaths, which is now done by addDependency itself for synchronisation purposes.
Ericson2314
approved these changes
Apr 13, 2026
Eveeifyeve
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Access to addedPaths/addedDrvOutputs was completely unsynchronised.
Context
Haven't yet been able to reproduce issues with this with thread sanitizers. The implementations seems kinda correct, but not 100% sure.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.