Automatically generate and use a signing key#15708
Automatically generate and use a signing key#15708lisanna-dettwyler wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
I think this should be done on the remote side. Singing builds that a different machine may have performed by default is a bit dangerous. But if the logic is moved to the local build code path, then it is safe. |
@Ericson2314 isn't that where I have it? |
|
Oh, I'm silly, there's already logic to sign paths with the contents of |
b46d76c to
9c8ea72
Compare
81114b9 to
b8db7b4
Compare
|
Tbh I'm not sure having the default be in |
b8db7b4 to
6657034
Compare
Sets the default value of `secret-key-files` to /nix/var/nix/keys/secret-key, and automatically generates this keypair if it doesn't exist. The effect of this is that locally built paths are always signed, making it easier to trace where builds come from and to establish trust. The corresponding public key is stored at `/nix/var/nix/public-keys/public-key`. Closes NixOS#3023 Signed-off-by: Lisanna Dettwyler <lisanna.dettwyler@gmail.com>
d072595 to
5c05fcd
Compare
Sets the default value of
secret-key-filesto/nix/var/nix/keys/secret-key, and automatically generates this keypair if it doesn't exist. The effect of this is that locally built paths are always signed, making it easier to trace where builds come from and to establish trust. The corresponding public key is stored at/nix/var/nix/public-keys/public-key.Closes #3023
Motivation
In addition to enabling tracing of what machine built what store path, this makes a future
--target-storeflag more usable, because you can obtain and add the automatically-generated public key of the remote store rather than having to manually generate and configure a new key.Context
#3023
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.