π‘οΈ Sentinel: [CRITICAL] Fix bare exceptions swallowing system signals - #30
π‘οΈ Sentinel: [CRITICAL] Fix bare exceptions swallowing system signals#30NoWon1 wants to merge 1 commit into
Conversation
Co-authored-by: NoWon1 <126711057+NoWon1@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Bare
except:blocks were used in multiple places withinSimulation/CancerInvasionSteppables.py.π― Impact: Bare exceptions catch all exceptions, including
BaseExceptionsubclasses likeKeyboardInterruptandSystemExit. If caught silently in tight spatial loops, this prevents the simulation from being safely terminated by the user or OS, leading to localized Denial of Service (DoS) and application unresponsiveness.π§ Fix: Replaced all bare
except:clauses withexcept Exception:, allowing critical system signals to propagate while still safely handling standard runtime errors. Also added an AST-based static analysis test (test_security.py) to ensure bare exceptions are not reintroduced.β Verification: Ran
bandit -r Simulation/to ensure no bare exceptions exist, and executedPYTHONPATH=$(pwd) python -m pytestto confirm the new static analysis test passes and the build is stable.PR created automatically by Jules for task 11905615005010871084 started by @NoWon1