A sub-packet's last field is its own, not the parent's - #503
Merged
Conversation
PacketSerializer passed the parent's maxIndex down when recursing into a
sub-packet, so whichever nested field happened to share that number inherited
the last-field exemption and kept its spaces. InPacket ends at index 9 and
InNonPlayerSubPacket.Name is index 9, so a spaced mate name went out as
in 2 333 2000001 ... -1 Joyeux Mouton 0 -1 ...
splitting the field. Each sub-packet now gets its own maxIndex, so the
exemption applies where a field really does end the line and nowhere else.
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #499, found while removing the manual escape from NosCoreIO/NosCore#2336.
The defect
PacketSerializerpassed the parent'smaxIndexdown when recursing into a sub-packet, soindexAttr.Index == maxIndexwas comparing a nested field's number against the outer packet's. Whichever nested field happened to share that number inherited the last-field exemption and kept its spaces.InPacketends at index 9.InNonPlayerSubPacket.Nameis index 9. So a spaced mate name went out aswhich is the same field-splitting #499 set out to fix — it just reached the name by a different route, and #499 did not cover it.
The change
Each sub-packet gets its own
maxIndex, so the exemption applies where a field really does end the line and nowhere else.sc_pandsc_nwere already correct because their names are plain properties, not nested ones.Tests
One new, pinning
inwith a spaced sub-packet name. It fails with the fix stashed and passes with it. 123 total, and the 115 that pin exact wire output are unchanged.Released as 21.1.1.