Skip to content

A spaced mate name reached the client as two fields #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 1 commit into from
Aug 30, 2026
Merged

A spaced mate name reached the client as two fields #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<PackageVersion Include="NosCore.Analyzers" Version="2.0.0" />
<PackageVersion Include="NosCore.Dao" Version="5.0.0" />
<PackageVersion Include="NosCore.Networking" Version="8.0.0" />
<PackageVersion Include="NosCore.Packets" Version="21.1.0" />
<PackageVersion Include="NosCore.Packets" Version="21.1.1" />
<PackageVersion Include="NosCore.PathFinder" Version="2.1.0" />
<PackageVersion Include="NosCore.Shared" Version="6.0.1" />
<PackageVersion Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.3" />
Expand Down
24 changes: 24 additions & 0 deletions test/NosCore.GameObject.Tests/Services/MateService/MateServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
using NosCore.Data.Dto;
using NosCore.Data.Enumerations.Character;
using NosCore.Data.StaticEntities;
using NosCore.Packets;
using NosCore.Packets.Interfaces;
using NosCore.Packets.ServerPackets.Mates;
using NosCore.Shared.Enumerations;
using System.Collections.Generic;
Expand Down Expand Up @@ -327,5 +329,27 @@ public async Task AMateIsNeverPlacedInsideAWallAsync()
Assert.IsTrue(walled.IsWalkable(mate.PositionX, mate.PositionY),
$"placed at {mate.PositionX},{mate.PositionY}, which is not walkable");
}

[TestMethod]
public async Task ASpacedMateNameReachesTheClientAsOneFieldAsync()
{
var service = Build(new[]
{
new MateDto { MateId = 1, CharacterId = CharacterId, VNum = ChickenVNum, MateType = MateType.Pet, IsTeamMember = true, Name = "Joyeux Mouton" }
}, Creature(ChickenVNum, "Chicken", 157, 10));

var mate = (await service.LoadAsync(CharacterId))[0];
var serializer = new Serializer(typeof(IPacket).Assembly.GetTypes()
.Where(p => p.GetInterfaces().Contains(typeof(IPacket)) && p.IsClass && !p.IsAbstract)
.ToList());

foreach (var packet in new IPacket[]
{ mate.GenerateIn(RegionType.EN), mate.GenerateScp(RegionType.EN), mate.GenerateScn(RegionType.EN) })
{
var line = serializer.Serialize(new[] { packet }).TrimEnd();
StringAssert.Contains(line, "Joyeux^Mouton",
$"the name has to travel as one field: {line}");
}
}
}
}
Loading