Skip to content

Take NosCore.Packets 21.1.0 and drop the manual mlintro escape #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 1 commit into from
Aug 30, 2026
Merged

Take NosCore.Packets 21.1.0 and drop the manual mlintro escape #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<PackageVersion Include="NosCore.Analyzers" Version="2.0.0" />
<PackageVersion Include="NosCore.Dao" Version="5.0.0" />
<PackageVersion Include="NosCore.Networking" Version="8.0.0" />
<PackageVersion Include="NosCore.Packets" Version="21.0.0" />
<PackageVersion Include="NosCore.Packets" Version="21.1.0" />
<PackageVersion Include="NosCore.PathFinder" Version="2.1.0" />
<PackageVersion Include="NosCore.Shared" Version="6.0.1" />
<PackageVersion Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.3" />
Expand Down
2 changes: 1 addition & 1 deletion src/NosCore.PacketHandlers/Miniland/MlobjPacketHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public override async Task ExecuteAsync(MLEditPacket mlEditPacket, ClientSession
switch (mlEditPacket.Type)
{
case 1:
await clientSession.SendPacketAsync(new MlintroPacket { Intro = mlEditPacket.MinilandInfo!.Replace(' ', '^') });
await clientSession.SendPacketAsync(new MlintroPacket { Intro = mlEditPacket.MinilandInfo });
miniland.MinilandMessage = mlEditPacket.MinilandInfo;
await clientSession.SendPacketAsync(new InfoiPacket
{
Expand Down
7 changes: 6 additions & 1 deletion test/NosCore.PacketHandlers.Tests/Miniland/MlEditPacketHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// |_|\__|\__/ |___/ \__/\__/|_|_\___|
//

using NosCore.Packets;
using Mapster;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
Expand Down Expand Up @@ -207,7 +208,11 @@ private void MinilandMessageWithSpaceShouldBeChanged()
var miniland = MinilandProvider.GetMiniland(Session.Character.CharacterId);
Assert.AreEqual("Test Test", miniland.MinilandMessage);
var lastpacket2 = (MlintroPacket?)Session.LastPackets.FirstOrDefault(s => s is MlintroPacket);
Assert.AreEqual("Test^Test", lastpacket2?.Intro);

// The packet carries the message as typed; the "^" encoding is the serializer's,
// which is why MlintroPacket.Intro declares EscapeSpaces.
Assert.AreEqual("Test Test", lastpacket2?.Intro);
Assert.AreEqual("mlintro Test^Test", new Serializer(new[] { typeof(MlintroPacket) }).Serialize(lastpacket2!));
}

private void InfoPacketShouldBeSent()
Expand Down
Loading