fix: deliver the SP cooldown-over message from the map tick, not a detached timer - #2357
Closed
erwan-joly wants to merge 2 commits into
Closed
fix: deliver the SP cooldown-over message from the map tick, not a detached timer#2357erwan-joly wants to merge 2 commits into
erwan-joly wants to merge 2 commits into
Conversation
LastSp lived only in the player component, so relogging cleared the transformation cooldown, and the cooldown-over message rode a detached fire-and-forget timer. LastSp now persists on Character (nullable column), login rehydrates it and re-arms the 30s window when it is still open, and the map life loop sweeps due notifications so a disconnected session is dropped instead of raced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
erwan-joly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture-review PR 4, rescoped after review: the SP cooldown is not supposed to survive a disconnect, so the persistence half (LastSp column, migration, login re-arm) is gone. What remains is the part that was genuinely broken:
sayi+sd 0) rodeObservable.Timer(...).Subscribe()— a detached fire-and-forget holding a session reference with no lifecycle awarenessSpCooldownNotificationService(swept by the map life loop) replaces it: due notifications are delivered on tick, sessions that logged out are dropped instead of racedTransformationService.SpCooldownSecondsManual checks added to
documentation/manual-test-plan.md: notification arrives on time in-game; logging out before the window ends delivers nothing and errors nothing.Build clean; GameObject.Tests 535/535, PacketHandlers.Tests 413/413.
🤖 Generated with Claude Code