chore(tests): drop two comments from the equipment stats tests - #2366
Conversation
One named another implementation, the other was left half-translated.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe change removes explanatory comments from ChangesEquipment test cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only removes redundant test comments and does not alter test behavior or production code; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to the equipment stats PR, applying the review note about comments to
what was already merged.
Both blocks say what the test names already say, and one had a stray Italian
word left in the middle of an English sentence.
What was tested
dotnet build: 0 warnings.dotnet test NosCore.sln: green, exceptBCardVocabularyTests.EveryDeclaredEffectIsNamed, which is marked[TestCategory("OPTIONAL-TEST")], fails onmastertoo, and is untouched here.What was NOT tested
Nothing to play: comments only, no behaviour changed.
Summary by CodeRabbit