Skip to content

chore(tests): drop two comments from the equipment stats tests - #2366

Merged
erwan-joly merged 1 commit into
NosCoreIO:masterfrom
denislauri1999:pr/equipment-stats-test-comments
Aug 30, 2026
Merged

chore(tests): drop two comments from the equipment stats tests#2366
erwan-joly merged 1 commit into
NosCoreIO:masterfrom
denislauri1999:pr/equipment-stats-test-comments

Conversation

@denislauri1999

@denislauri1999 denislauri1999 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the equipment stats PR, applying the review note about comments to
what was already merged.

Both blocks say what the test names already say, and one had a stray Italian
word left in the middle of an English sentence.

What was tested

dotnet build: 0 warnings. dotnet test NosCore.sln: green, except
BCardVocabularyTests.EveryDeclaredEffectIsNamed, which is marked
[TestCategory("OPTIONAL-TEST")], fails on master too, and is untouched here.

What was NOT tested

Nothing to play: comments only, no behaviour changed.

Summary by CodeRabbit

  • Tests
    • Removed outdated explanatory comments from equipment statistics tests.
    • No functional behavior or test coverage changes.

One named another implementation, the other was left half-translated.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d85e4a4-8e9c-4888-b8e7-db3c7ad19b92

📥 Commits

Reviewing files that changed from the base of the PR and between 6fe3098 and f41e796.

📒 Files selected for processing (1)
  • test/NosCore.GameObject.Tests/Services/EquipmentService/EquipmentStatsServiceTests.cs
💤 Files with no reviewable changes (1)
  • test/NosCore.GameObject.Tests/Services/EquipmentService/EquipmentStatsServiceTests.cs

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The change removes explanatory comments from AWeaponInTheBagCountsForNothing. The test setup and EquipmentStats.None assertion remain unchanged.

Changes

Equipment test cleanup

Layer / File(s) Summary
Remove obsolete test comments
test/NosCore.GameObject.Tests/Services/EquipmentService/EquipmentStatsServiceTests.cs
Removed comments from the weapon-in-equipment test. The test logic remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f41e7

This change only removes redundant test comments and does not alter test behavior or production code; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of two comments from the equipment stats tests, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erwan-joly
erwan-joly merged commit 177abad into NosCoreIO:master Aug 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants