Skip to content

CLAUDE.md: the serializer owns the wire format #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 1 commit into from
Aug 30, 2026
Merged

CLAUDE.md: the serializer owns the wire format #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ noise to the line. Do not add it; the calls still in the tree are not a preceden
**Keep semantic types.** Do not flatten a `bool` or an enum to a number because the wire
value happens to be `0` or `1`; the serializer handles the conversion.

**The serializer owns the wire format.** Never massage a value to fit it: no
`Replace(' ', '^')` before assigning a field, no manual padding, no hand-built separator. A
field that needs escaping says so on the packet property - `EscapeSpaces` for the one that
ends the line - so the fix belongs in `NosCore.Packets` and ships as a version bump. A
`Replace` here to make a packet come out right is a defect, including as a stopgap while
the package catches up.

**Ship only what is wired.** No placeholder enums, handlers or UI for behaviour that does
not exist yet. A data file listing a field is not a reason to expose it.

Expand Down
Loading