Skip to content

fix(bcard): the client spells it "hidden", not "hiden" #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 2 commits into from
Aug 31, 2026
Merged

fix(bcard): the client spells it "hidden", not "hiden" #2373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421e33a
feat(bcard): name the seven negated halves the client describes
denislauri1999 Aug 31, 2026
b6e6825
fix(bcard): the client spells it "hidden", not "hiden"
denislauri1999 Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions documentation/dat/BCard.dat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ Regenerate with `NOSCORE_DAT_FOLDER=<folder> dotnet test --filter BCardVocabular
| 62 | 51 | yes | HideBarrelSkillOnlyEnemiesWithBuffsAbove | Only applies to enemies with buffs above level %s. |
| 62 | 52 | yes | HideBarrelSkillOnlyEnemiesWithDebuffsAbove | Only applies to enemies with debuffs above level %s. |
| 63 | 11 | yes | FocusEnemyAttentionSkillFocusEnemyAttention | Attracts nearby enemies' attention to you. |
| 63 | 12 | yes | | |
| 63 | 12 | yes | FocusEnemyAttentionSkillFocusEnemyAttentionNegated | |
| 63 | 21 | yes | | |
| 63 | 22 | yes | | |
| 63 | 31 | yes | FocusEnemyAttentionSkillCookingExperienceIncreased | Cooking experience gain is increased by %s%%. |
Expand Down Expand Up @@ -875,15 +875,15 @@ Regenerate with `NOSCORE_DAT_FOLDER=<folder> dotnet test --filter BCardVocabular
| 87 | 51 | yes | Type87Unknow | Uses lich magic to create a Bone Drake and give the caster Dragon Vitality. |
| 87 | 52 | yes | Type87CreatesBoneDrake | Uses lich magic to create a Bone Drake and give the caster Strong Dragon Vitality. |
| 88 | 11 | yes | Type88MateReturnToMiniland | Return to Miniland and regenerate %s%% of your HP. If you have maximum HP, you receive %s%% additional HP. |
| 88 | 12 | yes | | |
| 88 | 21 | yes | Type88IncreaseDamageVsHiden | Attacks on hidden enemies cause %s additional damage. |
| 88 | 22 | yes | Type88DecreaseDamageVsHiden | |
| 88 | 31 | yes | Type88IncreaseDamageFromHiden | Damage from hidden enemies is increased by %s%%. |
| 88 | 32 | yes | Type88DecreaseDamageFromHiden | Damage from hidden enemies is reduced by %s%%. |
| 88 | 41 | yes | Type88RevealsHidenEnemy | Reveals hidden enemies within %s spaces. |
| 88 | 42 | yes | | |
| 88 | 12 | yes | Type88MateReturnToMinilandNegated | |
| 88 | 21 | yes | Type88IncreaseDamageVsHidden | Attacks on hidden enemies cause %s additional damage. |
| 88 | 22 | yes | Type88DecreaseDamageVsHidden | |
| 88 | 31 | yes | Type88IncreaseDamageFromHidden | Damage from hidden enemies is increased by %s%%. |
| 88 | 32 | yes | Type88DecreaseDamageFromHidden | Damage from hidden enemies is reduced by %s%%. |
| 88 | 41 | yes | Type88RevealsHiddenEnemy | Reveals hidden enemies within %s spaces. |
| 88 | 42 | yes | Type88RevealsHiddenEnemyNegated | |
| 88 | 51 | yes | Type88SkillResetXTimes | Skill can be used %s times without cooldown. |
| 88 | 52 | yes | | |
| 88 | 52 | yes | Type88SkillResetXTimesNegated | |
| 89 | 11 | yes | Type89Transform | Transform and assume the Dragon Stance with which you can carry out flame attacks. |
| 89 | 12 | yes | Type89RemoveTransform | Transform and assume the Haetae Stance with which you can carry out attacks using the power of the beast. |
| 89 | 21 | yes | Type89Unknow | Provides a %s%% probability to reset the cooldown of %s. |
Expand All @@ -907,11 +907,11 @@ Regenerate with `NOSCORE_DAT_FOLDER=<folder> dotnet test --filter BCardVocabular
| 91 | 11 | yes | Type91AddBuff | You dodge attacks and have a %s%% chance to cause %s. |
| 91 | 12 | yes | Type91DodgeAndAddBuffChance | You dodge attacks and have a %s%% chance to cause %s. |
| 91 | 21 | yes | Type91BuffSkillBooster | Use a buff skill while Enlightenment is active to receive additional effects. |
| 91 | 22 | yes | | |
| 91 | 22 | yes | Type91BuffSkillBoosterNegated | |
| 91 | 31 | yes | Type91AllowFullMoonSkill | Allows you to use Full Moon skills. |
| 91 | 32 | yes | | |
| 91 | 32 | yes | Type91AllowFullMoonSkillNegated | |
| 91 | 41 | yes | Type91AllowLotusPowerSkill | Allows you to use Lotus Flower skills. |
| 91 | 42 | yes | | |
| 91 | 42 | yes | Type91AllowLotusPowerSkillNegated | |
| 91 | 51 | yes | Type91ReduceCriticalDamageRecived | The next damage you inflict on a marked enemy will be increased by %s%% and consume the Mark of the Moon. |
| 91 | 52 | yes | Type91IncreaseCriticalDamageRecived | The next damage inflicted by the enemy will be reduced by %s%% and consume the Mark of the Moon. |
| 92 | 11 | yes | Type92AddBuffOnReceiveAttack | Whenever you are attacked, you have a %s%% chance of generating %s. |
Expand Down
17 changes: 12 additions & 5 deletions src/NosCore.Data/Enumerations/Buff/BCardEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@ public enum BCardEffect : short
HideBarrelSkillOnlyEnemiesWithDebuffsAbove = 6252,

FocusEnemyAttentionSkillFocusEnemyAttention = 6311,
FocusEnemyAttentionSkillFocusEnemyAttentionNegated = 6312,

FocusEnemyAttentionSkillCookingExperienceIncreased = 6331,
FocusEnemyAttentionSkillCookingExperienceReduced = 6332,
Expand Down Expand Up @@ -946,12 +947,15 @@ public enum BCardEffect : short

Type87CreatesBoneDrake = 8752,
Type88MateReturnToMiniland = 8811,
Type88IncreaseDamageVsHiden = 8821,
Type88DecreaseDamageVsHiden = 8822,
Type88IncreaseDamageFromHiden = 8831,
Type88DecreaseDamageFromHiden = 8832,
Type88RevealsHidenEnemy = 8841,
Type88MateReturnToMinilandNegated = 8812,
Type88IncreaseDamageVsHidden = 8821,
Type88DecreaseDamageVsHidden = 8822,
Type88IncreaseDamageFromHidden = 8831,
Type88DecreaseDamageFromHidden = 8832,
Type88RevealsHiddenEnemy = 8841,
Type88RevealsHiddenEnemyNegated = 8842,
Type88SkillResetXTimes = 8851,
Type88SkillResetXTimesNegated = 8852,

Type89Transform = 8911,
Type89RemoveTransform = 8912,
Expand All @@ -978,8 +982,11 @@ public enum BCardEffect : short
Type91AddBuff = 9111,
Type91DodgeAndAddBuffChance = 9112,
Type91BuffSkillBooster = 9121,
Type91BuffSkillBoosterNegated = 9122,
Type91AllowFullMoonSkill = 9131,
Type91AllowFullMoonSkillNegated = 9132,
Type91AllowLotusPowerSkill = 9141,
Type91AllowLotusPowerSkillNegated = 9142,
Type91ReduceCriticalDamageRecived = 9151,
Type91IncreaseCriticalDamageRecived = 9152,

Expand Down
Loading