Skip to content

ci: modernize deploy actions, pin ecs-deploy #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 3 commits into from
Aug 30, 2026
Merged

ci: modernize deploy actions, pin ecs-deploy #789

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85931aa
ci: modernize deploy actions, pin ecs-deploy
erwan-joly Aug 30, 2026
dfb1e96
ci: no credential persistence on checkout, pin ecs-deploy by commit
erwan-joly Aug 30, 2026
b8899ec
ci: pin ecs-deploy to the current master commit instead of v0.3.0
erwan-joly Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
Comment thread
coderabbitai[bot] marked this conversation as resolved.
with:
persist-credentials: false
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
Expand All @@ -23,7 +25,7 @@ jobs:

- name: Configure AWS Credentials
if: github.ref == 'refs/heads/master'
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand All @@ -32,7 +34,7 @@ jobs:
- name: Login to Amazon ECR
if: github.ref == 'refs/heads/master'
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
uses: aws-actions/amazon-ecr-login@v2

- name: Build, tag, and push image to Amazon ECR
if: github.ref == 'refs/heads/master'
Expand All @@ -43,14 +45,13 @@ jobs:
IMAGE_TAG: latest

run: |
docker build -f ./src/NosCoreBot/dockerfile -t noscorebot:$IMAGE_TAG --no-cache .
docker build -f ./src/NosCoreBot/dockerfile -t noscorebot:$IMAGE_TAG .
docker tag noscorebot:$IMAGE_TAG $ECR_REGISTRY/noscorebot:$IMAGE_TAG
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
echo "::set-output name=image::$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG"

- name: Deploy to Amazon ECS
if: github.ref == 'refs/heads/master'
uses: donaldpiret/ecs-deploy@master
uses: donaldpiret/ecs-deploy@b4c35d42b679ca60f35fa383cfbd71bcc9248a06 # master 2026-08 (v0.3.0 + dep CVE bumps)
with:
cluster: discordbot-cluster
target: noscorebot
Expand Down
Loading