Repository navigation
feat(data): fill in the Redmi Note 11, Galaxy A70 and other bare phones - #49
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
NotAFlightRisk
added
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Feature (data, no code)
Overview
Two dozen phones had a name and not much else - the Mi 9, 11T Pro, Redmi Note 11, Poco X4 Pro, Galaxy A70, Nord 2, the realme 5 to 7 lot. Mostly ones only crDroid, Evolution X or PixelOS build for, so no wiki to import from. This adds the year, chip, hardware and model numbers where I could back them up.
Specs are from GSMArena (through the Wayback Machine, as GSMArena bans you for 10 hours if you're quick), checked against Xiaomi, realme and OnePlus's own pages where they're still up. Model numbers are from MobileModels, which ties each to a codename, and only go in where the ROM's device tree says it installs on that model.
Issue Number
None
Additional Info
NFC goes in if any model a build covers has it, same as #33. The realme 5 and C3 trees ship NFC bits, but only behind realme's per-model switch, and GSMArena says none of those phones has it, so they dont get it.
Left alone: the Redmi 9A build also installs on the 9C (different chip, has a fingerprint reader), the Redmi 5 Plus' only page lumps its year in with the Redmi Note 5, and Teracube's site wouldn't load.
Some model numbers already sit on another device file, so there are more duplicates: rova vs mi8917, sunny vs mojito, and realme's rmx2001, rmx2151 and rmx3031 vs nemo, salaa and op6893. They want merging like #43 to #46, so those numbers are left off for now.
Validate, tests and build all pass.