Repository navigation
feat: music dialog lists (Up next, Recent, Playlists, Devices) - #52
Merged
Merged
Conversation
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
…nt tracks, playlists and devices The dialog's lists load on a 5 s timer while it shows, reset on close, /clear, Reconnect and disconnect, and a write answering NO_ACTIVE_DEVICE switches to Devices. A skip that finds its track gone says the spec's sentence, "That track already left the queue." Signed-off-by: NovusEdge <novusedge0@gmail.com>
Enter on a Recent, Playlists or Devices row that fails on a 5xx, a 429 or no answer now shows the list's reason inline instead of nothing, and a PREMIUM_REQUIRED on one no longer runs the local app, which has no form of these commands. Tests cover a late list answer after disconnect and connect, a 401 during a list load, and the list timer stopping on close. Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of four PRs for the music player: the lists in the music dialog, for a connected Spotify.
1–4: Up next, Recent, Playlists and Devices. Enter on a row plays it; nothing else starts playback (switching lists, opening, reloads and errors never do)./clear, on reconnect and on disconnect.Not checked live: every list needs a Spotify connection, which needs a developer app (#51 has the checklist, including whether the engine draws the list as a list at 88 columns).