fix: do not require libs.versions.toml alias names - #27
Merged
Conversation
…g-naming # Conflicts: # plugin-build/plugin/build.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Stop looking up the consumer project's version catalog when adding kotlinx-coroutines. The plugin now always injects those dependencies by Maven coordinates, using a plugin-owned default version.
📄 Motivation and Context
Fixes #26.
Published
0.6.0resolveskotlinx-coroutines-core(and related artifacts) from the consumerlibscatalog viaOptional.get(). A fresh KMP project — or any catalog that names the same library differently, e.g.kotlinx-coroutinesinstead ofkotlinx-coroutines-core— fails Gradle sync withNo value present.Plugins must not impose naming conventions on
libs.versions.toml.🧪 How Has This Been Tested?
No value presentinLibraries.kt:7kotlinx-coroutinesinstead ofkotlinx-coroutines-core→ same crashkotlinx-coroutinesaliashelp+generateKneNativeBridges):examples:calculator:generateKneNativeBridgesstill succeeds📦 Types of changes
✅ Checklist