Acknowledge network teardowns - #149
Merged
Merged
Conversation
…d reuse ids oldest-first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teardowns are now ack'd: VlanTeardown/VxlanTeardown carry an optional msg_id, the
client acks once the teardown has actually run, and the id returns to the pool
only then. The free is deferred to a detached task rather than awaited — callers
tear chains down in a loop — and still happens after a 30 s grace, emitting
net_teardown_unconfirmed, since a disconnected endpoint is normal on this path.Additionally, both pools reused the lowest freed id, handing one straight back out. They now
reuse oldest-freed-first, with a membership index so a double free cannot queue
an id twice.
Fixes #146