fix(airflow): mirror dagsGitSync.ref into branch - #62
Open
ibrahim-l wants to merge 2 commits into
Open
Conversation
… cannot override it Fixes OKDP#59.
There was a problem hiding this comment.
Pull request overview
This PR updates the Airflow package to prevent the Airflow chart’s default dags.gitSync.branch from implicitly setting the deprecated GIT_SYNC_BRANCH env var (which can override GITSYNC_REF in git-sync v4). It does this by mirroring dagsGitSync.ref into dagsGitSync.branch when the user did not provide a branch, ensuring the chart default no longer “wins”.
Changes:
- Bump Airflow package tag from
3.2.1-p04to3.2.1-p05. - When
dagsGitSync.refis provided and no branch is provided, setbranch = refbefore renderingdags.gitSyncvalues.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
abir-oumghar
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without a
branchkey the Airflow chart defaultdags.gitSync.branch: v2-2-stablelands in the deprecatedGIT_SYNC_BRANCHenv, which git-sync v4 lets overrideGITSYNC_REF, so the sidecar fetches the wrong ref and the pods stay in Init:Error. The package now mirrorsdagsGitSync.refintobranchwhen no branch is given.Related Issue
Fixes #59
Type of Change
How to Test
Deploy an Airflow Release with
dagsGitSync.refonly: the git-sync init container must fetch that ref (env shows the same value in both variables) instead of failing on v2-2-stable. Settingbranchexplicitly on the same Release was verified to fix the sync on a live instance.Checklist