fix(spark-history-server): keep the login on the proxy and drop the direct ingress - #63
fix(spark-history-server): keep the login on the proxy and drop the direct ingress#63ibrahim-l wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the spark-history-server package to ensure the OIDC login flow redirects back to the Spark History ingress host (instead of the web proxy host), addressing the cross-host state-cookie problem described in issue #60.
Changes:
- Bumps the package tag from
3.5.1-p07to3.5.1-p08. - Switches the history UI OIDC redirect base from the web-proxy endpoint to the history endpoint.
- Updates the configured OIDC
redirect-urivalue used byio.okdp.spark.authc.OidcAuthFilter.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
abir-oumghar
left a comment
There was a problem hiding this comment.
I would keep the proxy redirect-uri (suggestions below) and remove the direct history ingress instead: delete lines 108 to 123 (the ingress block of the main module) and then lines 90 and 91, whose variables become unused.
|
Tested end to end on a sandbox instance running this build: signing in through the web proxy lands back on the history UI with no 401 state-cookie error, and the removed direct history host now returns 404. |
Description
Entering through the direct
spark-history-<project>ingress ended onHTTP 401 The cookie 'OKDP_AUTH_SPARK_UI_STATE' is not present: the OIDC filter returned the Keycloak login to the proxy host while the state cookie lived on the history host. Per review, the proxy stays the single entry point: the redirect-uri keeps targeting the web proxy (/home) and the direct history ingress is removed, so the mismatched path no longer exists.Related Issue
Fixes #60
Type of Change
How to Test
Open
https://spark-web-proxy-<project>.<suffix>/home, log in on Keycloak: you must land back on the history UI instead of a 401.spark-history-<project>.<suffix>no longer resolves to an ingress.Checklist