Skip to content

fix(spark-history-server): keep the login on the proxy and drop the direct ingress - #63

Open
ibrahim-l wants to merge 3 commits into
OKDP:mainfrom
kubotal:fix/spark-history-own-redirect
Open

fix(spark-history-server): keep the login on the proxy and drop the direct ingress#63
ibrahim-l wants to merge 3 commits into
OKDP:mainfrom
kubotal:fix/spark-history-own-redirect

Conversation

@ibrahim-l

@ibrahim-l ibrahim-l commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description

Entering through the direct spark-history-<project> ingress ended on HTTP 401 The cookie 'OKDP_AUTH_SPARK_UI_STATE' is not present: the OIDC filter returned the Keycloak login to the proxy host while the state cookie lived on the history host. Per review, the proxy stays the single entry point: the redirect-uri keeps targeting the web proxy (/home) and the direct history ingress is removed, so the mismatched path no longer exists.

Related Issue

Fixes #60

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / chore
  • Breaking change

How to Test

Open https://spark-web-proxy-<project>.<suffix>/home, log in on Keycloak: you must land back on the history UI instead of a 401. spark-history-<project>.<suffix> no longer resolves to an ingress.

Checklist

  • I have tested my changes
  • Documentation updated if needed
  • If breaking change: migration path described above
  • I hereby declare this contribution to be licensed under the Apache License Version 2.0.
  • I hereby agree to grant TOSIT a copyright license to use my contributions.

Copilot AI lite review requested due to automatic review settings August 24, 2026 01:43
@ibrahim-l ibrahim-l self-assigned this Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the spark-history-server package to ensure the OIDC login flow redirects back to the Spark History ingress host (instead of the web proxy host), addressing the cross-host state-cookie problem described in issue #60.

Changes:

  • Bumps the package tag from 3.5.1-p07 to 3.5.1-p08.
  • Switches the history UI OIDC redirect base from the web-proxy endpoint to the history endpoint.
  • Updates the configured OIDC redirect-uri value used by io.okdp.spark.authc.OidcAuthFilter.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/services/spark-history-server/spark-history-server.yaml Outdated
Comment thread packages/services/spark-history-server/spark-history-server.yaml

@abir-oumghar abir-oumghar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the proxy redirect-uri (suggestions below) and remove the direct history ingress instead: delete lines 108 to 123 (the ingress block of the main module) and then lines 90 and 91, whose variables become unused.

Comment thread packages/services/spark-history-server/spark-history-server.yaml Outdated
Comment thread packages/services/spark-history-server/spark-history-server.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ibrahim-l

Copy link
Copy Markdown
Contributor Author

Tested end to end on a sandbox instance running this build: signing in through the web proxy lands back on the history UI with no 401 state-cookie error, and the removed direct history host now returns 404.

@ibrahim-l ibrahim-l changed the title fix(spark-history-server): send the login back to the history host fix(spark-history-server): keep the login on the proxy and drop the direct ingress Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spark-history-server package: the history ingress is unusable on its own host

3 participants