Skip to content

Fix sqlcipher iOS build: exclude libsql_experimental and turso_sdk_kit xcframeworks - #430

Merged
ospfranco merged 1 commit into
OP-Engineering:mainfrom
jean-losi:fix/sqlcipher-xcframework-excludes
Aug 5, 2026
Merged

Fix sqlcipher iOS build: exclude libsql_experimental and turso_sdk_kit xcframeworks#430
ospfranco merged 1 commit into
OP-Engineering:mainfrom
jean-losi:fix/sqlcipher-xcframework-excludes

Conversation

@jean-losi

Copy link
Copy Markdown
Contributor

Problem

With "sqlcipher": true and CocoaPods dynamic frameworks (use_frameworks! :linkage => :dynamic, e.g. an Expo prebuild with ios.useFrameworks: "dynamic"), the iOS build fails:

error: Multiple commands produce '.../op_sqlite.framework/Headers/libsql.h'

Root cause

The sqlcipher branch of op-sqlite.podspec still excludes only the obsolete ios/libsql.xcframework path:

exclude_files += [..., "ios/libsql.xcframework/**/*"]

but the package now ships ios/libsql_experimental.xcframework and ios/turso_sdk_kit.xcframework instead. Their headers land in source_files and collide. The other engine branches (libsql/turso) were updated to the new names — the sqlcipher branch was missed.

Affects at least 15.2.14 through 17.1.4 (the sqlcipher exclude list is identical on main today).

Fix

Add the two shipped xcframework globs to the sqlcipher exclude_files (kept the old ios/libsql.xcframework glob — it is harmless). SQLCipher builds use neither libsql nor the turso SDK, matching how the sibling branches exclude the engines they don't compile.

Verified by building an RN 0.86 app with sqlcipher + dynamic frameworks: the collision is gone and the app runs (we currently carry exactly this change as a pnpm patch on 15.2.14).

@ospfranco

Copy link
Copy Markdown
Contributor

awesome, thanks for the PR, once the tests pass I will do a release

@ospfranco
ospfranco merged commit ff23cd8 into OP-Engineering:main Aug 5, 2026
10 checks passed
@ospfranco

Copy link
Copy Markdown
Contributor

17.1.5 is building with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants