Fix sqlcipher iOS build: exclude libsql_experimental and turso_sdk_kit xcframeworks - #430
Merged
ospfranco merged 1 commit intoAug 5, 2026
Conversation
Contributor
|
awesome, thanks for the PR, once the tests pass I will do a release |
Contributor
|
17.1.5 is building with this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
"sqlcipher": trueand CocoaPods dynamic frameworks (use_frameworks! :linkage => :dynamic, e.g. an Expo prebuild withios.useFrameworks: "dynamic"), the iOS build fails:Root cause
The sqlcipher branch of
op-sqlite.podspecstill excludes only the obsoleteios/libsql.xcframeworkpath:but the package now ships
ios/libsql_experimental.xcframeworkandios/turso_sdk_kit.xcframeworkinstead. Their headers land insource_filesand collide. The other engine branches (libsql/turso) were updated to the new names — the sqlcipher branch was missed.Affects at least 15.2.14 through 17.1.4 (the sqlcipher exclude list is identical on
maintoday).Fix
Add the two shipped xcframework globs to the sqlcipher
exclude_files(kept the oldios/libsql.xcframeworkglob — it is harmless). SQLCipher builds use neither libsql nor the turso SDK, matching how the sibling branches exclude the engines they don't compile.Verified by building an RN 0.86 app with sqlcipher + dynamic frameworks: the collision is gone and the app runs (we currently carry exactly this change as a pnpm patch on 15.2.14).