Conversation
…ries (TEDEFO-5033)
rouschr
approved these changes
Apr 28, 2026
Contributor
rouschr
left a comment
There was a problem hiding this comment.
Looks like a useful improvement, less brute force than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates the slow
Reflectionsclasspath scan that made the EFX validator (and any other consumer ofSdkComponentFactory) prohibitively slow when run from a Spring Boot fat JAR (mdm-cli,mdm-war).Two changes in SdkComponentFactory:
.ignoreClassVisibility()preserves the previous behaviour of finding non-public@SdkComponentclasses.AnnotatedClassesHolderwhose result is shared across allSdkComponentFactorysubclasses (today:SdkEntityFactory,ComponentFactory,EfxTranslatorFactory). Three independent scans → one.Measured impact (mdm-cli
analyse-sdk --efxagainst eForms-SDK)Public API unchanged. Subclass constructors are unaffected.
Side effect: TEDEFO-3328
The
Reflectionsconfiguration relied onClassLoader.getDefinedPackages(), which only returns packages whose classes have already been initialised — the root cause of TEDEFO-3328 (components in a not-yet-touched JAR being missed). ClassGraph scans by classpath URL, so this trap is gone. We can likely close TEDEFO-3328 alongside this change.What is NOT addressed
The remaining
analyse-sdk --efxruntime (~9 minutes for SDK 2.0) is dominated by per-template translation work insideEfxTemplateTranslator.renderTemplate(), not by classpath scanning. That is a separate optimisation problem inefx-toolkit-javaand is being investigated separately.Test plan
eforms-core-javatests passefx-toolkit-javatests pass against the neweforms-core-javaSNAPSHOTeforms-sdk-analyzertests pass against the chainmdm-cli analyse-sdk --efxagainst eForms-SDK 2.0 source: same 158 errors found before and after the change (correctness preserved)