Fixing warning: unused variable - #7375
Open
daavid00 wants to merge 1 commit into
Open
Conversation
daavid00
added
the
manual:irrelevant
blattms
requested changes
Aug 31, 2026
Member
There was a problem hiding this comment.
I would consider this warning a false positive as this is a struct (at least if it happens in a header). Here it is in a cpp file and makes a bit more sense, but it assumes that the design of a class is just for the current implementation. That still seems a bit strange.
| struct Tolerance<double> | ||
| { | ||
| static constexpr double percent = 1e-10; | ||
| [[maybe_unused]] static constexpr double percent = 1e-10; |
Comment on lines
82
to
86
| template <> | ||
| struct Tolerance<float> | ||
| { | ||
| static constexpr float percent = 1e-3; | ||
| [[maybe_unused]] static constexpr float percent = 1e-3; | ||
| }; |
Member
There was a problem hiding this comment.
The whole specialization will not be used. Hence maybe we should prefer using a surround #if FLOW_INSTANTIATE_FLOAT
Member
Author
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing warning: unused variable 'percent'